Skip to content

Fix volatile_store and nontemporal_store #50648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2018
Merged

Fix volatile_store and nontemporal_store #50648

merged 2 commits into from
May 14, 2018

Conversation

nox
Copy link
Contributor

@nox nox commented May 11, 2018 •
edited
Loading

Fixes #50371.

@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 11, 2018
@nox
Copy link
Contributor Author

nox commented May 11, 2018

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned cramertj May 11, 2018
@eddyb
Copy link
Member

eddyb commented May 11, 2018

@bors r+

@bors
Copy link
Collaborator

bors commented May 11, 2018

📌 Commit 632e5e7 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2018
@eddyb eddyb added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 11, 2018
@eddyb
Copy link
Member

eddyb commented May 11, 2018

cc @nikomatsakis on the beta-nomination

@eddyb eddyb added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 11, 2018
@alexcrichton
Copy link
Member

@bors: p=1

(Beta nominated)

@bors
Copy link
Collaborator

bors commented May 13, 2018

🔒 Merge conflict

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 13, 2018
@nox nox force-pushed the volatile-store branch from 632e5e7 to 3ebe867 Compare May 13, 2018 08:37
@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 13, 2018
@kennytm
Copy link
Member

kennytm commented May 14, 2018

@bors r=eddyb

@bors
Copy link
Collaborator

bors commented May 14, 2018

📌 Commit 3ebe867 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2018
@bors
Copy link
Collaborator

bors commented May 14, 2018

⌛ Testing commit 3ebe867 with merge 7bfa20b...

bors added a commit that referenced this pull request May 14, 2018
@bors
Auto merge of #50648 - nox:volatile-store, r=eddyb
7bfa20b 
Fix volatile_store and nontemporal_store

Fixes #50371.
@bors
Copy link
Collaborator

bors commented May 14, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 7bfa20b to master...

@bors bors merged commit 3ebe867 into rust-lang:master May 14, 2018
@bors bors mentioned this pull request May 14, 2018
Merged
@pietroalbini pietroalbini mentioned this pull request May 14, 2018
Merged
@alexcrichton alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels May 14, 2018
bors added a commit that referenced this pull request May 15, 2018
@bors
Auto merge of #50741 - pietroalbini:beta-backports, r=alexcrichton
84b5a46 
[beta] Process backports

Merged on master:

* #50648: Fix volatile_store and nontemporal_store
* #50735: rustc: don't trip an assertion for enums with present but uninhabited variants.
* #50693: typeck: Save the index of private fields
* #50748: Update stdsimd module
* #50694: Fix self referential impl Trait substitutions

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nox @rust-highfive @eddyb @bors @alexcrichton @kennytm @cramertj